Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix silent refs failure #1254

Merged
merged 1 commit into from
May 21, 2015
Merged

fix silent refs failure #1254

merged 1 commit into from
May 21, 2015

Conversation

whyrusleeping
Copy link
Member

errors were being ignore in main.go, and on top of that, errors returned by readers cant be passed over http.

@whyrusleeping whyrusleeping added the status/in-progress In progress label May 20, 2015
@jbenet
Copy link
Member

jbenet commented May 20, 2015

Re based on master?

@jbenet
Copy link
Member

jbenet commented May 20, 2015

running the tests now-- seems they got stuck.

@jbenet
Copy link
Member

jbenet commented May 20, 2015

oh nvm you just force-pushed (thought it had been yellow for 15hrs)

@whyrusleeping
Copy link
Member Author

@jbenet still yellow.

jbenet added a commit that referenced this pull request May 21, 2015
@jbenet
Merge pull request #1254 from ipfs/fix/refs-fail
d51f28e 
fix silent refs failure
@jbenet jbenet merged commit d51f28e into master May 21, 2015
@jbenet jbenet removed the status/in-progress In progress label May 21, 2015
@jbenet jbenet deleted the fix/refs-fail branch May 21, 2015 03:25
@jbenet jbenet mentioned this pull request May 22, 2015
Closed
52 tasks
@wking wking mentioned this pull request Jun 12, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whyrusleeping @jbenet